NPE when calculating blame for hg

the NPE is coming from passing a null revision into infdb

conor: DvcsCache.getLongHash can certainly return null
MichaelH: yep, and it looks like we don't have any null checks in the CommonRevInfoDAO.getRevId methods
conor: should probably be in both places. It seems to be to do with hash expansion
conor: maybe not - blame must reference a hash which we don't have in the index?
MichaelH: That's likely, but should only happen if there are exclude rules in place?

• there are no excludes

may be related to http://img.skitch.com/20101108-fqa38j4k9hj9dm4mjjx3niqwfa.jpg

full stacktrace:
[java] 10:48:38 WARN - Could not retrieve blame for file src/content/WEB-INF/crucible.tld@83e1bc2b350ce23138266133b043e5a0c3400e83
[java] com.atlassian.fisheye.dvcs.handler.DvcsProcessException: Error while communicating with VCS:
[java] at com.atlassian.fisheye.dvcs.client.DvcsContext.executeCommand(DvcsContext.java:161)
[java] at com.atlassian.fisheye.hg.HgCache.getBlameFallback(HgCache.java:100)
[java] at com.cenqua.fisheye.rep.BaseLinecountCalculator.calcBlameFromScm(BaseLinecountCalculator.java:307)
[java] at com.cenqua.fisheye.rep.BaseLinecountCalculator.calcBlame(BaseLinecountCalculator.java:232)
[java] at com.cenqua.fisheye.rep.BaseLinecountCalculator.getRevIdData(BaseLinecountCalculator.java:133)
[java] at com.cenqua.fisheye.rep.BaseLinecountCalculator.indexRevisions(BaseLinecountCalculator.java:116)
[java] at com.cenqua.fisheye.rep.BaseLinecountCalculator.calcBlame(BaseLinecountCalculator.java:62)
[java] at com.cenqua.fisheye.rep.BaseRepositoryScanner.slurpRepository(BaseRepositoryScanner.java:321)
[java] at com.cenqua.fisheye.rep.BaseRepositoryScanner.doSlurpTransaction(BaseRepositoryScanner.java:252)
[java] at com.cenqua.fisheye.rep.BaseRepositoryScanner.ping(BaseRepositoryScanner.java:187)
[java] at com.cenqua.fisheye.rep.BaseRepositoryEngine.doSlurp(BaseRepositoryEngine.java:85)
[java] at com.cenqua.fisheye.rep.RepositoryEngine.slurp(RepositoryEngine.java:387)
[java] at com.cenqua.fisheye.rep.ping.OneOffPingRequest.doRequest(OneOffPingRequest.java:25)
[java] at com.cenqua.fisheye.rep.ping.PingRequest.process(PingRequest.java:66)
[java] at com.cenqua.fisheye.rep.RepositoryHandle.processPingRequests(RepositoryHandle.java:129)
[java] at com.cenqua.fisheye.rep.RepositoryHandle.queuePingRequest(RepositoryHandle.java:119)
[java] at com.cenqua.fisheye.rep.ping.PingRequest.run(PingRequest.java:33)
[java] at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
[java] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
[java] at java.lang.Thread.run(Thread.java:637)
[java] Caused by: com.atlassian.utils.process.ProcessException: While executing: "hg --config ui.verbose=false annotate -r 83e1bc2b350ce23138266133b043e5a0c3400e83 -c -f -l src/content/WEB-INF/crucible.tld"
[java] at com.atlassian.fisheye.dvcs.client.DvcsContext.executeCommand(DvcsContext.java:196)
[java] at com.atlassian.fisheye.dvcs.client.DvcsContext.executeCommand(DvcsContext.java:179)
[java] at com.atlassian.fisheye.dvcs.client.DvcsContext.executeCommand(DvcsContext.java:159)
[java] ... 19 more
[java] Caused by: com.atlassian.utils.process.ProcessException: java.lang.NullPointerException
[java] at com.atlassian.utils.process.ExternalProcess$4.doTask(ExternalProcess.java:189)
[java] at com.atlassian.utils.process.LatchedRunnable.run(LatchedRunnable.java:21)
[java] ... 3 more
[java] Caused by: java.lang.NullPointerException
[java] at com.infinitydb.Cu.append(InfinityDB_1.0.53:1427)
[java] at com.cenqua.fisheye.rep.impl.CommonRevInfoDAO.getRevId(CommonRevInfoDAO.java:147)
[java] at com.cenqua.fisheye.rep.impl.CommonRevInfoDAO.getRevId(CommonRevInfoDAO.java:139)
[java] at com.cenqua.fisheye.rep.impl.CommonRevInfoDAO.getRevId(CommonRevInfoDAO.java:131)
[java] at com.cenqua.fisheye.cache.BaseRevisionCache.getRevId(BaseRevisionCache.java:658)
[java] at com.atlassian.fisheye.dvcs.DvcsCache.getRevId(DvcsCache.java:79)
[java] at com.atlassian.fisheye.dvcs.DvcsCache.getFileRevision(DvcsCache.java:120)
[java] at com.atlassian.fisheye.hg.HgCache$1.endChunk(HgCache.java:109)
[java] at com.atlassian.fisheye.hg.client.HgBlameParser.processChunkLine(HgBlameParser.java:40)
[java] at com.atlassian.fisheye.hg.client.HgBlameParser.doProcessLine(HgBlameParser.java:23)
[java] at com.atlassian.fisheye.dvcs.handler.DvcsLineOutputHandler.processLine(DvcsLineOutputHandler.java:19)
[java] at com.atlassian.utils.process.LineOutputHandler.process(LineOutputHandler.java:39)
[java] at com.atlassian.utils.process.PluggableProcessHandler.processOutput(PluggableProcessHandler.java:34)
[java] at com.atlassian.utils.process.ExternalProcess$4.doTask(ExternalProcess.java:186)
[java] ... 4 more
[java] 10:48:42 WARN - Could not retrieve blame for file src/content/WEB-INF/tags/cru/dirtree/branchSelector.tag@83e1bc2b350ce23138266133b043e5a0c3400e83
[java] com.atlassian.fisheye.dvcs.handler.DvcsProcessException: Error while communicating with VCS:
[java] at com.atlassian.fisheye.dvcs.client.DvcsContext.executeCommand(DvcsContext.java:161)
[java] at com.atlassian.fisheye.hg.HgCache.getBlameFallback(HgCache.java:100)
[java] at com.cenqua.fisheye.rep.BaseLinecountCalculator.calcBlameFromScm(BaseLinecountCalculator.java:307)
[java] at com.cenqua.fisheye.rep.BaseLinecountCalculator.calcBlame(BaseLinecountCalculator.java:232)
[java] at com.cenqua.fisheye.rep.BaseLinecountCalculator.getRevIdData(BaseLinecountCalculator.java:133)
[java] at com.cenqua.fisheye.rep.BaseLinecountCalculator.indexRevisions(BaseLinecountCalculator.java:116)
[java] at com.cenqua.fisheye.rep.BaseLinecountCalculator.calcBlame(BaseLinecountCalculator.java:62)
[java] at com.cenqua.fisheye.rep.BaseRepositoryScanner.slurpRepository(BaseRepositoryScanner.java:321)
[java] at com.cenqua.fisheye.rep.BaseRepositoryScanner.doSlurpTransaction(BaseRepositoryScanner.java:252)
[java] at com.cenqua.fisheye.rep.BaseRepositoryScanner.ping(BaseRepositoryScanner.java:187)
[java] at com.cenqua.fisheye.rep.BaseRepositoryEngine.doSlurp(BaseRepositoryEngine.java:85)
[java] at com.cenqua.fisheye.rep.RepositoryEngine.slurp(RepositoryEngine.java:387)
[java] at com.cenqua.fisheye.rep.ping.OneOffPingRequest.doRequest(OneOffPingRequest.java:25)
[java] at com.cenqua.fisheye.rep.ping.PingRequest.process(PingRequest.java:66)
[java] at com.cenqua.fisheye.rep.RepositoryHandle.processPingRequests(RepositoryHandle.java:129)
[java] at com.cenqua.fisheye.rep.RepositoryHandle.queuePingRequest(RepositoryHandle.java:119)
[java] at com.cenqua.fisheye.rep.ping.PingRequest.run(PingRequest.java:33)
[java] at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
[java] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
[java] at java.lang.Thread.run(Thread.java:637)
[java] Caused by: com.atlassian.utils.process.ProcessException: While executing: "hg --config ui.verbose=false annotate -r 83e1bc2b350ce23138266133b043e5a0c3400e83 -c -f -l src/content/WEB-INF/tags/cru/dirtree/branchSelector.tag"
[java] at com.atlassian.fisheye.dvcs.client.DvcsContext.executeCommand(DvcsContext.java:196)
[java] at com.atlassian.fisheye.dvcs.client.DvcsContext.executeCommand(DvcsContext.java:179)
[java] at com.atlassian.fisheye.dvcs.client.DvcsContext.executeCommand(DvcsContext.java:159)
[java] ... 19 more
[java] Caused by: com.atlassian.utils.process.ProcessException: java.lang.NullPointerException
[java] at com.atlassian.utils.process.ExternalProcess$4.doTask(ExternalProcess.java:189)
[java] at com.atlassian.utils.process.LatchedRunnable.run(LatchedRunnable.java:21)
[java] ... 3 more
[java] Caused by: java.lang.NullPointerException
[java] at com.infinitydb.Cu.append(InfinityDB_1.0.53:1427)
[java] at com.cenqua.fisheye.rep.impl.CommonRevInfoDAO.getRevId(CommonRevInfoDAO.java:147)
[java] at com.cenqua.fisheye.rep.impl.CommonRevInfoDAO.getRevId(CommonRevInfoDAO.java:139)
[java] at com.cenqua.fisheye.rep.impl.CommonRevInfoDAO.getRevId(CommonRevInfoDAO.java:131)
[java] at com.cenqua.fisheye.cache.BaseRevisionCache.getRevId(BaseRevisionCache.java:658)
[java] at com.atlassian.fisheye.dvcs.DvcsCache.getRevId(DvcsCache.java:79)
[java] at com.atlassian.fisheye.dvcs.DvcsCache.getFileRevision(DvcsCache.java:120)
[java] at com.atlassian.fisheye.hg.HgCache$1.endChunk(HgCache.java:109)
[java] at com.atlassian.fisheye.hg.client.HgBlameParser.processChunkLine(HgBlameParser.java:40)
[java] at com.atlassian.fisheye.hg.client.HgBlameParser.doProcessLine(HgBlameParser.java:23)
[java] at com.atlassian.fisheye.dvcs.handler.DvcsLineOutputHandler.processLine(DvcsLineOutputHandler.java:19)
[java] at com.atlassian.utils.process.LineOutputHandler.process(LineOutputHandler.java:39)
[java] at com.atlassian.utils.process.PluggableProcessHandler.processOutput(PluggableProcessHandler.java:34)
[java] at com.atlassian.utils.process.ExternalProcess$4.doTask(ExternalProcess.java:186)
[java] ... 4 more
[java] 10:48:47 WARN - Could not retrieve blame for file src/content/WEB-INF/tags/cru/dirtree/branchSelector.tag@1069caf3a55cc6cf8ab3b49204717096c8f3b62b
[java] com.atlassian.fisheye.dvcs.handler.DvcsProcessException: Error while communicating with VCS:
[java] at com.atlassian.fisheye.dvcs.client.DvcsContext.executeCommand(DvcsContext.java:161)
[java] at com.atlassian.fisheye.hg.HgCache.getBlameFallback(HgCache.java:100)
[java] at com.cenqua.fisheye.rep.BaseLinecountCalculator.calcBlameFromScm(BaseLinecountCalculator.java:307)
[java] at com.cenqua.fisheye.rep.BaseLinecountCalculator.calcBlame(BaseLinecountCalculator.java:232)
[java] at com.cenqua.fisheye.rep.BaseLinecountCalculator.getRevIdData(BaseLinecountCalculator.java:133)
[java] at com.cenqua.fisheye.rep.BaseLinecountCalculator.indexRevisions(BaseLinecountCalculator.java:116)
[java] at com.cenqua.fisheye.rep.BaseLinecountCalculator.calcBlame(BaseLinecountCalculator.java:62)
[java] at com.cenqua.fisheye.rep.BaseRepositoryScanner.slurpRepository(BaseRepositoryScanner.java:321)
[java] at com.cenqua.fisheye.rep.BaseRepositoryScanner.doSlurpTransaction(BaseRepositoryScanner.java:252)
[java] at com.cenqua.fisheye.rep.BaseRepositoryScanner.ping(BaseRepositoryScanner.java:187)
[java] at com.cenqua.fisheye.rep.BaseRepositoryEngine.doSlurp(BaseRepositoryEngine.java:85)
[java] at com.cenqua.fisheye.rep.RepositoryEngine.slurp(RepositoryEngine.java:387)
[java] at com.cenqua.fisheye.rep.ping.OneOffPingRequest.doRequest(OneOffPingRequest.java:25)
[java] at com.cenqua.fisheye.rep.ping.PingRequest.process(PingRequest.java:66)
[java] at com.cenqua.fisheye.rep.RepositoryHandle.processPingRequests(RepositoryHandle.java:129)
[java] at com.cenqua.fisheye.rep.RepositoryHandle.queuePingRequest(RepositoryHandle.java:119)
[java] at com.cenqua.fisheye.rep.ping.PingRequest.run(PingRequest.java:33)
[java] at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
[java] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
[java] at java.lang.Thread.run(Thread.java:637)
[java] Caused by: com.atlassian.utils.process.ProcessException: While executing: "hg --config ui.verbose=false annotate -r 1069caf3a55cc6cf8ab3b49204717096c8f3b62b -c -f -l src/content/WEB-INF/tags/cru/dirtree/branchSelector.tag"
[java] at com.atlassian.fisheye.dvcs.client.DvcsContext.executeCommand(DvcsContext.java:196)
[java] at com.atlassian.fisheye.dvcs.client.DvcsContext.executeCommand(DvcsContext.java:179)
[java] at com.atlassian.fisheye.dvcs.client.DvcsContext.executeCommand(DvcsContext.java:159)
[java] ... 19 more
[java] Caused by: com.atlassian.utils.process.ProcessException: java.lang.NullPointerException
[java] at com.atlassian.utils.process.ExternalProcess$4.doTask(ExternalProcess.java:189)
[java] at com.atlassian.utils.process.LatchedRunnable.run(LatchedRunnable.java:21)
[java] ... 3 more
[java] Caused by: java.lang.NullPointerException
[java] at com.infinitydb.Cu.append(InfinityDB_1.0.53:1427)
[java] at com.cenqua.fisheye.rep.impl.CommonRevInfoDAO.getRevId(CommonRevInfoDAO.java:147)
[java] at com.cenqua.fisheye.rep.impl.CommonRevInfoDAO.getRevId(CommonRevInfoDAO.java:139)
[java] at com.cenqua.fisheye.rep.impl.CommonRevInfoDAO.getRevId(CommonRevInfoDAO.java:131)
[java] at com.cenqua.fisheye.cache.BaseRevisionCache.getRevId(BaseRevisionCache.java:658)
[java] at com.atlassian.fisheye.dvcs.DvcsCache.getRevId(DvcsCache.java:79)
[java] at com.atlassian.fisheye.dvcs.DvcsCache.getFileRevision(DvcsCache.java:120)
[java] at com.atlassian.fisheye.hg.HgCache$1.endChunk(HgCache.java:109)
[java] at com.atlassian.fisheye.hg.client.HgBlameParser.processChunkLine(HgBlameParser.java:40)
[java] at com.atlassian.fisheye.hg.client.HgBlameParser.doProcessLine(HgBlameParser.java:23)
[java] at com.atlassian.fisheye.dvcs.handler.DvcsLineOutputHandler.processLine(DvcsLineOutputHandler.java:19)
[java] at com.atlassian.utils.process.LineOutputHandler.process(LineOutputHandler.java:39)
[java] at com.atlassian.utils.process.PluggableProcessHandler.processOutput(PluggableProcessHandler.java:34)
[java] at com.atlassian.utils.process.ExternalProcess$4.doTask(ExternalProcess.java:186)
[java] ... 4 more