[#CRUC-85] Sometimes we need to see differences in UNICODE files.

Crucible

Sometimes we need to see differences in UNICODE files.

Created: 05/Oct/07 04:47 PM Updated: 22/Apr/08 01:25 AM

Component/s:

None

Affects Version/s:

None

Fix Version/s:

1.5

Time Tracking:

Not Specified

Issue Links:

Cloners

This issue was cloned as:

~~CRUC-99~~ Feature request: I would like to see statistics about number of major and minor issues found per developer.

Duplicate

This issue duplicates:

~~FE-5~~ [P4] need to consider "utf8" etc file types

Reference

This issue is related to:

CRUC-365 UTF-16 little endian file recognized as binary

Participants:	Conor MacNeill [Atlassian], David Hergert, Lubos Mikusiak and Matt Quail [Atlassian]
Since last comment:	26 weeks, 3 days ago
Resolution Date:	09/Apr/08 08:08 PM
Labels:

Description

« Hide

1. Sometimes we need to see differences in UNICODE files. These are, for example, files with localized messages. Crucible does not seem to be able to handle UNICODE files. Last time I tried to see the differences, Crucible simply displayed the latest version of the file.

Best regards,

Lubos

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

David Hergert added a comment - 09/Oct/07 04:27 PM

I agree with the second point. I would like to be able to see the types of comments that a particular developer gets. Or at the very least, for a given review, see all the comments and their severity in a single concise view.

[ Permlink | « Hide ]

Matt Quail [Atlassian] added a comment - 09/Oct/07 06:15 PM

I am going to clone this issue to separate the two points.

[ Permlink | « Hide ]

Matt Quail [Atlassian] added a comment - 09/Oct/07 06:19 PM

Lubos,

Crucible should handle Unicode files, or at least it should be able to show the differences. Can you see diffs for these files in the FishEye pages?

What version of Crucible are you using, and what version control system are you using (CVS, SVN, Perforce, etc)?

Can you perhaps grab a screenshot of a review were Crucible would not show the diff, and perhaps send us a copy of the Unicode file in question?

[ Permlink | « Hide ]

Lubos Mikusiak added a comment - 23/Oct/07 04:50 AM

The files for which I wanted to see the difference are stored by P4 as binary files. Does this explain why Crucible does not show the differences?

[ Permlink | « Hide ]

Matt Quail [Atlassian] added a comment - 23/Oct/07 07:12 PM

Yes, if Crucible thinks the file is "binary", then it will not show a diff. At the moment, FishEye/Crucible only considers files with a file type of "text" as text files.
http://www.perforce.com/perforce/doc.072/manuals/cmdref/o.ftypes.html#1040647

Can you confirm that the files in question are UNICODE or utf16?

[ Permlink | « Hide ]

Lubos Mikusiak added a comment - 24/Oct/07 03:24 AM

The files are UTF-16 encoded.

[ Permlink | « Hide ]

Conor MacNeill [Atlassian] added a comment - 06/Feb/08 10:37 PM

So, the files are known to Perforce as binary files but are actually unicode files?

[ Permlink | « Hide ]

Lubos Mikusiak added a comment - 07/Feb/08 01:53 AM

Correct.

[ Permlink | « Hide ]

Conor MacNeill [Atlassian] added a comment - 07/Feb/08 03:50 PM

That's a little more difficult to handle. We are adding support for the unicode filetype in both unicode and regular p4 servers but we accept the server's view with regard to content being binary. Does the content have the Unicode BOM?

[ Permlink | « Hide ]

Lubos Mikusiak added a comment - 08/Feb/08 02:53 AM

I made one mistake above. We use UTF-8 encoded files. It is UTF-8 BOM-less encoding.

[ Permlink | « Hide ]

Conor MacNeill [Atlassian] added a comment - 25/Feb/08 12:02 AM

I'm going to mark this as wontfix, at least for now. If the repository thinks the file is binary, FishEye will treat the file as binary regardless of the actual content. Determining the possible content type of an arbitrary binary file is not something FishEye will do in the short term. We are considering some solutions in the longer term (custom file type handlers, for example).