Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-3708

NPE when access review where repo deleted

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Highest
    • 2.4-M7, 2.4.0
    • 2.3.3, 2.3.4, 2.3.5
    • None

    Description

      Replication steps :
      1. Create a repository
      2. Create a project that uses the repository above as its default repository
      3. Create a review in the previously created project
      4. Access the review from the previous step to confirm it works
      5. Delete the repository created in step #1
      6. Try to access the same review as in #4 and see that it now throws a NPE

      15:20:48 ERROR - Nested in javax.servlet.ServletException: javax.el.ELException: java.lang.NullPointerException:
      javax.el.ELException: java.lang.NullPointerException
      	at javax.el.BeanELResolver.getValue(BeanELResolver.java:298)
      	at javax.el.CompositeELResolver.getValue(CompositeELResolver.java:175)
      	at com.sun.el.parser.AstValue.getValue(AstValue.java:138)
      	at com.sun.el.ValueExpressionImpl.getValue(ValueExpressionImpl.java:206)
      	at org.apache.jasper.runtime.PageContextImpl.evaluateExpression(PageContextImpl.java:1001)
      	at org.apache.jsp.tag.web.review.frxModelLoader_tag.doTag(frxModelLoader_tag.java:175)
      ..............
      Caused by: java.lang.NullPointerException
      	at com.cenqua.crucible.view.FRXDO.isStoreDiffs(FRXDO.java:477)
      	at com.cenqua.crucible.view.FRXDO.isShowBlame(FRXDO.java:1247)
      	at com.cenqua.crucible.view.FRXDO.getDiffColumns(FRXDO.java:482)
      

      Users should be able to see the general details of a review, even if the repository and the source code on which that review are based have been deleted. This assumes that we have configured Crucible to store diff info.

      Attachments

        Activity

          People

            jxie Chii
            tlum Tracey Lum [Atlassian]
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: