Low - In hgfelog.py, the MetaChange detection is too simplistic: a duplicate modification on a second branch shows up as a MetaChange because the file rev on the other branch is re-used. hgsubversion and hgconvert both produce commits from svn merges that have filerevs whose linkrev is not the current commit.
- In FishEye, we create a new revision, but it's parent rev is the last content change revsions parent, instead of the last content change revision, because that's what mercurial stores in it's filectx. We'd have to detect that and cope with it.
- In FE, a subsequent content mod will also have as it's parent the previous content mod revision, instead of the perm change revision, again, because that's what mercurial stores.
- relates to
-
FE-3325 HG: Add basic Mercurial Slurp tests
- Closed
[FE-3101] HG: Cope with MetaChanges (permission changes)
The tests are currently failing, because a perm change to an added file is reported as an added file instead of a change.
It currently generates the wrong parent information for the subsequent commit.
Bigger issue - how to deal with MetaChange revisions - in FE at the moment, we create a new revision, but a subsequent modification will have the last modified revision as it's parent, not out rev with the permission change, because that is what mercurial tells us is the parent rev.
By comparing the flags on the file to the repo[rev][file].flags() to the repo[repo[rev][file].linkrev()][file].flags() (i.e. the flags on the current commit with the flags in the linkrev commit) I can tell if it is a permission change vs a file that is either a duplicate modification on another branch or a result of hgsubversion/hgconvert simulating a merge.
Hi everyone,
This issue has been reported several years ago for version older than 3.0.0, which is over 18 major releases behind the latest Fisheye/Crucible version. Additionally, it has not get interest since the time it has been reported. Therefore, we decided to close the issue as Timed Out.
If you still see this bug occurring in the latest release and a fix is very important for you, please don't hesitate to share your feedback in the issue comments. We will continue to watch the issue for further updates.
Cheers
Marek Parfianowicz
Fisheye/Crucible TL