Details
-
Suggestion
-
Resolution: Obsolete
-
None
-
None
Description
It breaks a whole lot of functionality in Crucible, and we don't handle it gracefully.
If you do so, you get random null pointer exceptions
e.g trying to add a patch to a review:
java.lang.NullPointerException at com.cenqua.crucible.revision.source.PatchSource.makeFileRevisionInfo(PatchSource.java:412) at com.cenqua.crucible.model.managers.PatchManager.makeFromRevision(PatchManager.java:60) at com.cenqua.crucible.model.managers.PatchManager.createFileRevisions(PatchManager.java:50) at com.cenqua.crucible.model.managers.PatchManager.createPatch(PatchManager.java:40) at com.atlassian.crucible.spi.impl.DefaultReviewService$6.doInTransaction(DefaultReviewService.java:342) at com.atlassian.crucible.spi.impl.DefaultReviewService$6.doInTransaction(DefaultReviewService.java:330)
The UI will just spin if you try to add an attachment or patch to a review etc.