[#CONF-9866] Replace System.out, System.err and printStackTrace references with logging

Confluence

Replace System.out, System.err and printStackTrace references with logging

Created: 01/Nov/07 08:32 PM Updated: 15/Nov/07 11:54 PM

Component/s:

Logging & Auditing

Affects Version/s:

2.6.0

Fix Version/s:

2.6.2

Time Tracking:

Not Specified

Participants:	David Taylor [Atlassian], Paul Curren [Atlassian] and Per Fragemann [Atlassian]
Since last comment:	41 weeks, 3 days ago
Resolution Date:	15/Nov/07 11:54 PM
Labels:

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

David Taylor [Atlassian] added a comment - 06/Nov/07 09:24 PM

Performed the replacements and some small refactors when working through code local to the logging. One class DefaultReferralManager had a unit test broken by a code reorder so a new test was written to test that edge case.

[ Permlink | « Hide ]

Per Fragemann [Atlassian] added a comment - 13/Nov/07 07:32 PM

Looked at all files. The logging changes are good, the refactoring great. but:

ForgotUserPasswordAction: missing ,e in the logging of the exception
ConfluenceTrackbackStore: can't find any tests at all, would suggest to have a test for the newly extracted method
DefaultReferralManager: no tests available for the changed ordering of referToContent (would recommend testing with empty referrer and zero hitcount)