Issue Details (XML | Word | Printable)

Key: CONF-9590
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Andrew Lynch [Atlassian]
Reporter: Jon Nermut
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Confluence

ConfluenceEntityObject.log is not static?

Created: 27/Sep/07 09:22 PM   Updated: 10/Oct/07 06:29 PM
Component/s: Engine Room / Architecture, Plugin Framework
Affects Version/s: 2.6.0
Fix Version/s: 2.6.1

Time Tracking:
Not Specified

Participants: Andrew Lynch [Atlassian], Jon Nermut and Matt Ryall [Atlassian]
Since last comment: 1 year, 8 weeks ago
Internal Complexity: 1
Resolution Date: 10/Oct/07 06:29 PM
Internal Value: 7
Labels:


 Description  « Hide
Trying to track down an issue in the upgrade of Subconf to conf 2.6, I saw that ConfluenceEntityObject.log is declared as

protected final Logger log = Logger.getLogger(getClass());

i.e. not static

I don't have the source yet for 2.6 so couldn't see if this was deliberate, but it stuffs me trying to use XStream as a neat easy way to serialise objects because
1. XStream now tries to serialize this object, which spews heaps of xml and an exception when you try to deserialize
and
2. the version of XStream in conf 2.6 doesnt have the XStream.omitField method

Also aren't there performance implications of creating a log for every entity object?

If this is deliberate, shouldn't the field be marked as transient?



 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Matt Ryall [Atlassian] added a comment - 28/Sep/07 12:06 AM
You're right, Jon. This should be static. Thanks for letting us know.

Jon Nermut added a comment - 28/Sep/07 12:10 AM
No worries. I guess despite the pain it must cause you, the benefit of having an open platform is another set of eyes on the code.

Have a good grand final weekend!