|
[
Permlink
| « Hide
]
David Peterson added a comment - 10/Apr/07 10:53 AM
This is a major problem - particularly since you're now bundling TOC with Confluence. Could we please go back to <a> tags for headings?
The change that caused this was
In the meantime, if you do wish to revert to the old behaviour, you can change the renderer component responsible for this to the old implementation by editing WEB-INF/classes/wikiFiltersSubsystemContext.xml Find the line in the v2BlockComponentsBean that reads: <bean class="com.atlassian.confluence.renderer.NoAnchorHeadingBlockRenderer"/> and change it to <bean class="com.atlassian.confluence.renderer.ConfluenceHeadingBlockRenderer"/> Restart confluence and anchors will be used once more. Is this getting fixed sometime soon? I'm getting about 3 requests a week a the moment...
This is apparently also a problem with commas, question marks and other non-alphanumeric characters.
More and more people in my company are taking up firefox, so this is becoming a big issue for us. Based on what's described here (http://www.w3.org/TR/html401/struct/links.html
 ), what you guys did were the correct thing. Ideally, Firefox should fix their bug. I'll file a bug report there, but based on my experience with an Ajax bug Mozilla family has, it could take years before it gets fixed. In the meantime, I hope you guys could find a better way. Hmm, spoke too soon. Seems it's still a Confluence bug. I checked further and found Firefox implementation actually does conform to what's described at http://www.w3.org/TR/html401/struct/links.html
. Based on the allowed character set for HTML element IDs (http://www.w3.org/TR/html401/types.html#type-name), it only allows [A-Za-z0-9_.:-]. Firefox supports all of them. Additionally, ',', '%' etc. (in fact most of the printable characters), are supported in Firefox.
So it's really not a firefox problem as it does conform to the standards. Upon further inspection, I found that the reason why some links do not work in Firefox is because of the escaping in the IDs. For example, the following situation would work in Firefox: <a href="#:">test</a> So does: <a href="#%3A">test</a> But not: <a href="#%3A">test</a> This suggests that Firefox only unescapes the URI in <a> (correct behavior) but not ID (again, I believe it's the correct behavior too. Why should browsers unescape characters in IDs? Unicode argument does not apply here. In fact, it's surprising that other browsers would all be behaving incorrectly including Opera, as suggested by the other user). So here're my suggestions as to how one could address this problem: 1. One could change the code in com.atlassian.confluence.renderer.NoAnchorHeadingBlockRenderer to escape the string in <a>, but do not escape them in <h2 id... etc. This, however, runs into the risk that some characters MUST be escaped. For example, " 2. One could escape the code in both <a> and <h2 id... BUT get rid of the '%' after escaping the string. This way you're left with a unique, standards-conforming string for both link and ID and they'd work in all browsers. What's more, I do not understand the logic of escaping everything except for space character, which was just discarded. It seems to me if the space is not regarded as important for uniqueness, so are all the punctuations, which are all escaped by your renderer after removing space. So the method 2 above should be used for space character too and the result would have guaranteed uniqueness even for any situation. So instead of removing space then escape, the procedure should become (not remove space), escape, then remove % character. BTW, I also noticed that your renderer for some reason was using the deprecated ' in <a href='uri'> instead of <a href="uri">. " should be used instead of '. We have been discussing this internally here at Atlassian and it is likely now given the limited character set that may be placed in the id of an element that we will revert to using an empty anchor with a name. This is the only way we can proceed while preserving existing links to document fragments.
While you're fixing the problem, could you possibly change the anchor generation algorithm to not drop out instantly when it encounters a non-alphanumeric? If you nave a macro in a title (eg. ) all your anchors end up being the same name - ie 'PageName-'... Not terribly helpful.
By the way, I understand the motivation for the original change - it's a pity FireFox doesn't play along, the 'id' arrangement is definitely much neater.
It isn't Firefox's fault. It is simply following the standards to do with HTML ID character sets. We could workaround it by changing the encoding standard but that has ramifications for existing links with fragment identifiers. Pity that.
We have reverted to the original behaviour, i.e. a named anchor.
didn't make 2.5 cutoff
Hmm, so I guess the existing document fragments links are hard-coded that's why you can't change encoding now.
But anyway reverting back is probably better given that it's always a little worrisome that those elements (like <h2>) are forced to have an id, which could interfere with other macros (if any) that also need to modify element ids. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
Bug
Resolved
Critical
Header anchors do not work in Firefox with non-ASCII characters
