Issue Details (XML | Word | Printable)

Key: CONF-8050
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Matthew Jensen [Atlassian]
Reporter: Scott Farquhar [Atlassian]
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Confluence

zip_src from tiny mce served without caching headers on extranet

Created: 13/Mar/07 06:42 PM   Updated: 02/Apr/07 08:14 PM
Component/s: Performance, Web Interface, WYSIWYG editing
Affects Version/s: 2.4
Fix Version/s: 2.4.3

Time Tracking:
Not Specified

File Attachments: None
Image Attachments:

1. Picture 6.png
(127 kB)
Environment: Version: 2.4 Build:#702 Feb 21, 2007
Issue Links:
Cloners
 

Participants: Matthew Jensen [Atlassian] and Scott Farquhar [Atlassian]
Since last comment: 1 year, 33 weeks, 3 days ago
Resolution Date: 02/Apr/07 08:09 PM
Labels:


 Description  « Hide
Currently this URL causes a 12 second slow-down when loading the edit page on extranet:

http://extranet.atlassian.com/includes/js/tiny_mce/zip_src?theme=advanced&language=en&plugins=table%2Cpaste%2Cemotions%2Cfullscreen%2Cconfluence

It is approx 300kb of content that is sent uncompressed, and sent every time (as it has the must-revalidate header):

Date: Tue, 13 Mar 2007 23:33:16 GMT
Server: Apache/2.0.52 (Red Hat)
X-Confluence-Cluster-Node: Member(Id=2, Timestamp=2007-03-09 04:22:50.186, Address=172.16.0.10:8088, MachineId=57135)
Cache-Control: must-revalidate
Expires: Wed, 14 Mar 2007 00:33:16 GMT
Content-Length: 302263
Connection: close
Content-Type: text/javascript

We should fix this to serve it through the caching servlet "/s". To do this, we can't pass any parameters to the url, as by default, most browsers won't cache requests that have request parameters.

I'm raising this as a bug, as it causes severe performance penalties over slow connections. 300kb on every edit.



 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Matthew Jensen [Atlassian] added a comment - 14/Mar/07 07:25 PM
The wiki-textarea.vm page makes a call to the tiny_mce servlet without parameters which returns with javascript that builds up the real url to retrieve the tiny mce javascript.

Plan
1. Modify TinyMCE servlet to return a url without parameters. The options will be encoded in the URL somehow in a non-parameter way to allow for caching.
2. Modify the TinyMCE servlet to interpret the parameters from the encoded URL.
3. Add a URLRewrite rule in web.xml to pass this new URL throw the ResourceDownloadUtils addCacheHeaders method.


Matthew Jensen [Atlassian] added a comment - 15/Mar/07 12:47 AM
Fix committed for 2.4.3

Matthew Jensen [Atlassian] added a comment - 19/Mar/07 06:31 PM
In the trunk this issue needs to be reapplied because of conflict with work done on making the editor pluginable.

Matthew Jensen [Atlassian] added a comment - 02/Apr/07 07:36 PM
This fix used an absolute URL which causes problems with the baseURL property changes or the confluence instance is running in a multi homed environment.

Need to update it to handle these cases.


Matthew Jensen [Atlassian] added a comment - 02/Apr/07 08:09 PM
Opening a new issue for the url changes.