[#CONF-5954] ConfluenceSoapServiceImpl.changeMyPassword() incorrectly delegates to SoapServiceDelegator.changeUserPassword

Confluence

ConfluenceSoapServiceImpl.changeMyPassword() incorrectly delegates to SoapServiceDelegator.changeUserPassword

Created: 19/Apr/06 03:57 PM Updated: 29/May/07 02:07 AM

Component/s:

Remote API (SOAP & XML-RPC)

Affects Version/s:

2.1.5

Fix Version/s:

2.5.3, 2.6.0

Time Tracking:

Not Specified

Participants:	Asgeir Nilsen, Jens Schumacher [Atlassian], Paul Curren [Atlassian] and Tom Davies [Atlassian]
Since last comment:	1 year, 26 weeks, 5 days ago
Resolution Date:	29/May/07 02:07 AM
Labels:

Description

« Hide

From ConfluenceSoapServiceImpl.java :

346: public boolean changeMyPassword(String token, String oldPass, String newPass) throws InvalidSessionException, RemoteException
347- { 348- return soapServiceDelegator.changeUserPassword(token, oldPass, newPass); 349- }

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Jens Schumacher [Atlassian] added a comment - 21/Apr/06 12:19 AM

Thanks, we'll take a look at this.

[ Permlink | « Hide ]

Paul Curren [Atlassian] added a comment - 29/May/07 02:07 AM

This was fixed as described.

To write a unit test for this style of bug, a Mock instance of the soapServiceDelegator would need to be instantiated and then a test per method on the delegating ConfluenceSoapServiceImpl class ensuring that the matching method on the Mock was called.

This would be a lot of development to test what is basically a typo. I've run this opinion past Charles who is in agreement.