|
It seems that the servlet that delivers style sheets produces a more useful header so it should therefore be relatively straightforward to get the resources servlet doing the same?
Response Headers - http://www.statprowiki.com/styles/main-action.css?pluginCompleteKey=org.randombits.confluence.composition:composition-setup&stylesheetName=deck&spaceKey=SER Date: Wed, 01 Feb 2006 20:37:57 GMT 200 OK Hi Matt,
Has there been any updates on this issue - it's really causing us a great deal of trouble. As we are using Confluence primarily as a CMS with lots of visual macros pulling resources from the servlet, it's causing some of our sites to grind to an absolute halt. Guy Guy,
We acknowledge that is an issue, but have yet to schedule time to implement the fix. Cheers, I would consider this to be a higher priority issue than 'Minor' - it will have a big effect on many plugins, particularly as they become more sophisticated.
We've got some clients who are having problems due to this issue as their sites are viewed via modem - in such cases reloading even the smallest file repeatedly causes massive delays.
So yes, if the priority could be icreased a little it would be most appreciated. The JavaPolis 2006 confluence site would like to use the Adaptavist builder theme (like we're doing for SpringOne.com site)
but if the plugins are not cached we might be forced not to use it because of the response delay of the confluence plugins  So please, please make sure you can fix this in the next release of Confluence !! Thanks in advance, To implement this correctly, the plugin subsystem would need to know when each plugin was last modified. We could then use that for the modification date header.
To implement this hackily, we could just keep the same last-modified time for all plugin resources, and reset it whenever any plugin is enabled/disabled/installed/uninstalled. The hacky way would be fine for now (and probably long term IMHO) - just reset the date each time a plugin is installed, etc., as you say
 Hi Charles,
Would it be possible for us to get hold of a Confluence 2.2 before the general release - we've got lots of clients who are "chomping at the bit" for the improved performance this will offer so we'd like to test Builder and our other visual macros prior to release rather than have a flood of bugs reported when people suddenly start upgrading ahead of us. We are also aware that it won't be a magic bullet for all performance issues, so we're keen to set client expectations about the performance boost and provide them with tips for making their home page faster (eg. don't flood it with a gazillion graphical plugins like we do hehe). FYI: We're drooling over some of the additional features and bug fixes in 2.2, especially from a plugin development point of view Guy Hi Guy,
We will consider to release a DR [1] next week, based on our progress. Please note that this will be a DR and might not be as stable as the final release. Since 2.0 we haven't had any Developer Releases so it is actually a good idea to provide one if it proves useful for you. Cheers, [1] http://confluence.atlassian.com/display/DOC/Development+Releases Dan gave me a preview of two Confluence installs earlier this evening - one with his patch for the resource servlet, and one without. With "Fasterfox" set to default speed settings, the patched version was twice as fast!
 Similar performance increases were seen on Internet Exploder and Opera also
Hopefully we'll be able to patch our hosted clients within the next 48 hours or so and we'll certainly be contributing the code back to the community as it really does speed up the performance of plugins that pull assets from the resources servlet (much more than I had expected or hoped for). Bear in mind that this applies not just to graphics, but javascript files, css files, etc. Cached resources here we come! Yay! Thanks for the info Guy.
This will be awesome for macros requiring lots of JavaScript like the dynamic task-list. I've rolled this fix into Confluence 2.2 (atlassian-plugins-0.3.22)
Thanks, guys! |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
Bug
Resolved
Major
Plugin resource servlet does not provide headers necessary for caching
It would also be useful to get the content-disposition added (not just for files loaded from resources, but also for word and PDF exports if possible: when I click on the export links, by default it tries to save a file with the same name as the server side action name, but I digress).
Response Headers - http://www.adaptavist.com/download/attachments/918/cubes.png
Date: Wed, 01 Feb 2006 06:31:17 GMT
Server: Resin/3.0.14
Last-Modified: Thu, 12 Jan 2006 19:33:10 GMT
Etag: "1137094390000"
content-disposition: inline; filename="cubes.png"
Content-Type: image/png
Content-Length: 2146
200 OK