[#CONF-3995] getRenderMode() returning null does not render contained macros - Atlassian JIRA

Confluence

getRenderMode() returning null does not render contained macros

Created: 10/Sep/05 11:20 AM Updated: 09/Oct/09 07:25 PM

Return to search

Component/s:

Macros -- General, Plugins, Renderer

Affects Version/s:

1.4.3

Fix Version/s:

None

Time Tracking:

Not Specified

Issue Links:

Reference

This issue relates to:

~~CONF-8534~~ Using excerpt-include doesn't render the body in the {excerpt} macro when it contains {note} or {code} or {noformat}

Participants:	David Peterson, Guy Fraser [Adaptavist.com], Jens Schumacher [Atlassian], Paul Curren [Atlassian] and Simon Wheatley
Since last comment:	2 years, 6 weeks, 4 days ago
Internal Complexity:	4
Internal Value:	4
Labels:	mojito
Support reference count:	3

Description

« Hide

If you write a macro which returns null from the getRenderMode() method, the documentation says the rendering engine will expect wiki text back from the execute() method and will render it after calling execute(). This is basically true, except that any macros in the returned text will not be rendered - they will just be output, {}'s and all.

As a workaround, you can return text which has had just the macros rendered, but I'm not sure if this is a safe thing to do, since many macros will return XHTML, and I have no idea what will happen when that gets passed through the engine...

Sort Order:

[ Permalink | « Hide ]

Jens Schumacher [Atlassian] added a comment - 13/Sep/05 01:37 AM

Thanks for pointing that out David.

[ Permalink | « Hide ]

David Peterson added a comment - 07/Oct/05 09:35 AM

Ok, this seems to be a general problem with RenderMode.INLINE, unless I'm missunderstanding what 'things you'd normally find inside a paragraph' means. If you render using the SubRenderer with RenderMode.INLINE, macros are not rendered in 1.4.4. I'm not sure about 1.4.3 - I don't have an install to test it any more. This is a very annoying issue...any chance of a 1.4.5 coming out before 1.5 is released with a fix for some remaining stuff, or is 1.4 dead?

[ Permalink | « Hide ]

David Peterson added a comment - 15/Nov/07 07:23 PM

Is this issue every going to get looked at? It's still happening in 2.6.1, albeit in a slightly different form - the macro is executed, but any wiki content that it contains is unrendered... Try writing a macro which outputs {include:Another Page}, and put some markup on the 'Another Page', for example...

[ Permalink | « Hide ]

Paul Curren [Atlassian] added a comment - 15/Nov/07 08:53 PM

Hi David,

the issue will get looked at, and the plan is reasonably soon but could still be a while away (we have a large number of higher priority issues).

Thanks.

[ Permalink | « Hide ]

Simon Wheatley added a comment - 19/Dec/07 11:39 AM

This bug is still evident in 2.7, is it moving up your priority list at all? It's causing issues with me relating to:
http://jira.adaptavist.com/browse/VISIB-29

[ Permalink | « Hide ]

Guy Fraser [Adaptavist.com] added a comment - 20/Dec/07 07:55 AM

We've seen this error manifest itself on several client sites after upgrading to recent versions of Confluence (not sure if some were 2.6.2, but we've seen it a lot in 2.7).

[ Permalink | « Hide ]

Guy Fraser [Adaptavist.com] added a comment - 20/Dec/07 10:04 AM

If anyone is hitting this bug using the show-to and hide-from macros in the Visibility plugin, downgrading the plugin to an earlier version seems to provide an interim workaround. However, I'm not sure if you can use the older versions on Confluence 2.7 due to permissions system changes.

[ Permalink | « Hide ]

Paul Curren [Atlassian] added a comment - 26/Dec/07 05:52 PM

Simon, this defect is on our priority list. However, it's still some distance from the top of the list.
Thanks.