Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-18093

DefaultUserProfileService tries to modify an unmodifiable collection (PATCH)

XMLWordPrintable

      DefaultUserProfileServies#setServletContext relies on an implementation detail of some servlet containers that return a modifiable collection upon calling ServletContext#getResourcePaths. Since this is not guaranteed by the servlet spec a safer approach should be used as follows:

      diff -r b525e9b6e14e -r 019c14125676 apps/confluence/confluence-project/confluence/src/java/com/atlassian/confluence/user/service/DefaultUserProfileService.java
--- a/apps/confluence/confluence-project/confluence/src/java/com/atlassian/confluence/user/service/DefaultUserProfileService.java       Fri Dec 18 23:45:51 2009 -0800
+++ b/apps/confluence/confluence-project/confluence/src/java/com/atlassian/confluence/user/service/DefaultUserProfileService.java       Sat Dec 19 00:29:42 2009 -0800
@@ -14,6 +14,7 @@

 import java.io.InputStream;
 import java.util.Set;
+import java.util.HashSet;

 public class DefaultUserProfileService implements UserProfileService, ServletContextAware
 {
@@ -55,7 +56,7 @@
     @SuppressWarnings("unchecked")
     public void setServletContext(ServletContext servletContext)
     {
-        buildInProfilePics = servletContext.getResourcePaths(UserAccessor.PROFILE_PICTURE_BUILTIN_PATH);
+        buildInProfilePics = new HashSet<String>(servletContext.getResourcePaths(UserAccessor.PROFILE_PICTURE_BUILTIN_PATH));
         CollectionUtils.filter(buildInProfilePics, new Predicate()
         {
             public boolean evaluate(Object object)

      This patch allows Confluence 3.1 to work properly with GlassFish v3.

            [CONFSERVER-18093] DefaultUserProfileService tries to modify an unmodifiable collection (PATCH)

            Katherine Yabut made changes -
            Workflow Original: JAC Bug Workflow v3 [ 2894581 ] New: CONFSERVER Bug Workflow v4 [ 2985597 ]
            Owen made changes -
            Workflow Original: JAC Bug Workflow v2 [ 2779903 ] New: JAC Bug Workflow v3 [ 2894581 ]
            Status Original: Resolved [ 5 ] New: Closed [ 6 ]
            Owen made changes -
            Workflow Original: JAC Bug Workflow [ 2734522 ] New: JAC Bug Workflow v2 [ 2779903 ]
            Owen made changes -
            Workflow Original: Confluence Workflow - Public Facing - Restricted v5 - TEMP [ 2399935 ] New: JAC Bug Workflow [ 2734522 ]
            Katherine Yabut made changes -
            Workflow Original: Confluence Workflow - Public Facing - Restricted v5 [ 2299047 ] New: Confluence Workflow - Public Facing - Restricted v5 - TEMP [ 2399935 ]
            Katherine Yabut made changes -
            Workflow Original: Confluence Workflow - Public Facing - Restricted v5.1 - TEMP [ 2233655 ] New: Confluence Workflow - Public Facing - Restricted v5 [ 2299047 ]
            Katherine Yabut made changes -
            Workflow Original: Confluence Workflow - Public Facing - Restricted v5 - TEMP [ 2195179 ] New: Confluence Workflow - Public Facing - Restricted v5.1 - TEMP [ 2233655 ]
            Katherine Yabut made changes -
            Workflow Original: Confluence Workflow - Public Facing - Restricted v5 [ 1927118 ] New: Confluence Workflow - Public Facing - Restricted v5 - TEMP [ 2195179 ]
            Katherine Yabut made changes -
            Workflow Original: Confluence Workflow - Public Facing - Restricted v3 [ 1736846 ] New: Confluence Workflow - Public Facing - Restricted v5 [ 1927118 ]
            Katherine Yabut made changes -
            Workflow Original: CONF Bug Subtask WF (TEMP) [ 1695495 ] New: Confluence Workflow - Public Facing - Restricted v3 [ 1736846 ]

              xtjhin Joshua Tjhin (Inactive)
              15d9a6950818 Igor Minar
              Affected customers:
              0 This affects my team
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: