[#CONF-11582] Macro for printable icon should not include <li> tags

Confluence

Macro for printable icon should not include <li> tags

Created: 27/Apr/08 06:35 PM Updated: 18/May/08 10:20 PM

Component/s:

Web Interface

Affects Version/s:

2.8

Fix Version/s:

2.8.1, 2.9

Time Tracking:

Not Specified

Participants:	Don Willis [Atlassian], Igor Minar, Matt Ryall [Atlassian] and Matthew Jensen [Atlassian]
Since last comment:	28 weeks, 1 day ago
Resolution Date:	04/May/08 09:44 PM
Labels:

Description

« Hide

The #printableicon macro now includes <li> tags around the image. This is different behavior than pre 2.8 causing some themes to render differently.

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Matthew Jensen [Atlassian] added a comment - 27/Apr/08 06:36 PM

To work around this issue you need to put the icon in a <ul> and use CSS to disable the bullets.

[ Permlink | « Hide ]

Matthew Jensen [Atlassian] added a comment - 27/Apr/08 06:44 PM

From the user mailing list:

In upgrading to Confluence 2.8, I've discovered that the printable icon that used to be in the upper right of most pages is no longer part of the default UI. In trying to get it back I have added the following table to main.vmd:

<div id="main">
<table style="padding: 0px; margin: 0px 5px; width: 100%;">
<tr align="right">
<td>
#printableicon()
</td>
</tr>
</table>
$!sitemeshPage.getProperty("page.pageoutputs")
#usernavbar()
$!sitemeshPage.getProperty("page.content-navigation")

This change positions the icon on the dashboard and other pages in the upper right of the UI, just above the 'Tools' menu (more or less where it used to be). However, an unwanted side effect of this is a list item bullet directly across from printer icon in the upper left of the UI. Any ideas how I can get rid of the bullet? Or a better way to add the printable icon and functionality back to the UI? Ideally, the printer icon would be next to the 'Tools' menu for a better look and feel, but I have been unsuccessful in achieving that positioning. I usually end up with an overlap of the icon and the menu.

Thanks for any suggestions,

[ Permlink | « Hide ]

Don Willis [Atlassian] added a comment - 04/May/08 09:43 PM

We have removed the <li> tags from the macro in 2.8.1 and 2.9. Our apologies to those who have changed their themes for 2.8 and will now have to change them again for the reversion.

[ Permlink | « Hide ]

Igor Minar added a comment - 13/May/08 11:38 AM

Don't you think that it would be a good idea to add "print this page" to the "Tools" drop down menu?

[ Permlink | « Hide ]

Matt Ryall [Atlassian] added a comment - 18/May/08 10:20 PM

Igor, we removed the printable view from the default theme intentionally. Confluence now has a print stylesheet that we'll be improving as a replacement for the old "printable" decorator. This is a much more scalable solution for us, and has widespread browser support these days.

You can make any further comments on the new UI in the discussion space here:

http://confluence.atlassian.com/display/DISC/2.8+UI+Discussion