[#BAM-574] The interface used to provide a view of artifacts has issues dealing with subdirectories

Bamboo

The interface used to provide a view of artifacts has issues dealing with subdirectories

Created: 19/Dec/06 01:26 AM Updated: 04/May/07 03:04 AM

Component/s:

Build Artifacts

Affects Version/s:

1.0.3

Fix Version/s:

1.1

Time Tracking:

Not Specified

File Attachments:

FileServingServlet.java (10 kB)

Internal Priority:	2. High
Participants:	Ajay Sridhar [Atlassian], Ben Walding, Brydie McCoy [Atlassian], Chris Henson, Edwin Wong [Atlassian] and Matthew smith
Since last comment:	1 year, 16 weeks, 6 days ago
Internal Work Bucket:	Confirmed
Number of comments:	6
Labels:

Description

« Hide

When browsing the artifacts for a build...

I might have several items while browsing http://host/download/PROJECT-MAIN/artifacts/build-142/output/module/module/

Parent Directory
pmd.html 783580 bytes Dec 19, 2006 12:50:12 AM
cobertura.ser 271357 bytes Dec 19, 2006 12:50:01 AM
coverage 20480 bytes Dec 19, 2006 12:50:23 AM
classes 4096 bytes Dec 19, 2006 12:49:57 AM
test-reports 20480 bytes Dec 19, 2006 12:50:23 AM
instrumented-classes 4096 bytes Dec 19, 2006 12:49:57 AM
test-classes 4096 bytes Dec 19, 2006 12:49:57 AM
src 4096 bytes Dec 19, 2006 12:49:57 AM

When browsing into test-reports for instance:

http://host/download/PROJECT-MAIN/artifacts/build-142/output/module/module/test-reports

I am never redirected to

http://host/download/PROJECT-MAIN/artifacts/build-142/output/module/module/test-reports/ (note trailing slash)

With the unslashed version, the resulting relative links in the index.html in test-reports dir are not generated correctly (by the web browser), rendering the web page incorrectly (since in my case it uses frames).

I realise this is a horrible description - basically the links in higher directories should either have a trailing slash, or the handler should redirect to a trailing slashed directory rather than just rendering the content to an unslashed URL.

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Ajay Sridhar [Atlassian] added a comment - 20/Mar/07 08:10 PM

Hi Ben,

Apologies for the late reply. We are looking at fixing the bug

Cheers,
Ajay

[ Permlink | « Hide ]

Chris Henson added a comment - 24/Mar/07 08:50 PM

I patched the FileServingServlet to ignore welcome files (it really should do a redirect). Fixes the problem.

I also added a patch to accept /latest/ instead of the build number so you can always reference the latest build's artifacts from somewhere.

[ Permlink | « Hide ]

Chris Henson added a comment - 24/Mar/07 08:51 PM

Patched to ignore welcome files and to respect /latest/ in the URL.

[ Permlink | « Hide ]

Edwin Wong [Atlassian] added a comment - 30/Mar/07 02:50 AM

Hey Chris,

Thanks for looking into this. We'll get two putting this one in.

Cheers,
Edwin

[ Permlink | « Hide ]

Matthew smith added a comment - 03/May/07 08:59 AM

We would love to have this fixed. It's presenting some problems for us in maven multi-module builds which collect artifacts from child projects. More details here: http://forums.atlassian.com/thread.jspa?threadID=17442&tstart=0

[ Permlink | « Hide ]

Brydie McCoy [Atlassian] added a comment - 04/May/07 03:04 AM

Hi,

Thanks for your patch, Chris, it helped us get to the bottom of the problem. I have made changes perform the redirection for directories. These changes should be included in the 1.1 release.

Also, I will create another issue for the 'latest' artifacts links. You can track that issue there (http://jira.atlassian.com/browse/BAM-1180)

Cheers
Brydie