Issue Details (XML | Word | Printable)

Key: BAM-456
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Mark Chaimungkalanont [Atlassian]
Reporter: Nick Sieger
Votes: 0
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
Bamboo

Code change filenames from CVS branch have "Attic" in the path

Created: 20/Nov/06 08:59 AM   Updated: 01/Jan/07 05:50 PM
Component/s: Repository (CVS)
Affects Version/s: 0.6
Fix Version/s: 0.7.1

Time Tracking:
Not Specified

File Attachments: None
Image Attachments:

1. code-changes.png
(44 kB)
Issue Links:
Cloners
 

Participants: Mark Chaimungkalanont [Atlassian] and Nick Sieger
Since last comment: 2 years, 2 weeks, 4 days ago
Number of comments: 6
Labels:


 Description  « Hide
Most of our checkins are to CVS branches where the repository records the change in the special "Attic" directory. This is propagating into Bamboo, where the ViewCVS/Fisheye links contain the "Attic/" path in them, thus they are broken. Could you filter file paths for the Attic and remove it?

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Nick Sieger added a comment - 20/Nov/06 09:05 AM
Small screenshot of code changes screen

Mark Chaimungkalanont [Atlassian] added a comment - 20/Nov/06 08:14 PM
Nick,

Thanks for pointing that out. We'll try to squeeze the change in for 0.7 for you

Cheers,

Mark C


Mark Chaimungkalanont [Atlassian] added a comment - 20/Nov/06 10:53 PM
Nick,

I can't reproduce your exact problem (ie on the branch). AFAIK, "/Attic" should really only appear if your file has been removed from CVS, so I'm not 100% what the problem is in your case.

We have, however, made sure we removed the "/Attic" from the URL in 0.7 and any FishEye links with attic in it should now work.

Cheers,

Mark C


Nick Sieger added a comment - 21/Nov/06 08:53 AM
Mark, I know what the issue is. If you want, you could try it out.

What we have is files that were only created on branches and don't actually have any revisions on the trunk.

You should be able to reproduce like this:

<go to some test directory>
cvs tag -b test_branch
cvs update -r test_branch
touch test.txt
cvs add test.txt
cvs ci

Here's example "cvs log" output for such a file:

Working file: test.txt
head: 1.1
branch:
locks: strict
access list:
symbolic names:
        test_branch: 1.1.0.2
keyword substitution: kv
total revisions: 2;     selected revisions: 2
description:
----------------------------
revision 1.1
date: 2006/11/21 14:52:20;  author: nsieger;  state: dead;
branches:  1.1.2;
file test.txt was initially added on branch test_branch.
----------------------------
revision 1.1.2.1
date: 2006/11/21 14:52:20;  author: nsieger;  state: Exp;  lines: +0 -0
- adding a file on test_branch
=============================================================================

Nick Sieger added a comment - 21/Nov/06 08:54 AM
At any rate, thanks for the quick response and the fix! Looking forward to trying it.

Nick Sieger added a comment - 22/Dec/06 02:48 PM
Hi Mark, the fix works great, but you forgot to remove "Attic" from the link text itself – only a cosmetic issue, but it'd be great if you cleaned it up. Thanks!