Uploaded image for project: 'Bamboo Data Center'
  1. Bamboo Data Center
  2. BAM-2488

Bamboo should not run post-build actions and send out notifications, when it fails to save the buildresultsummary

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Medium
    • 2.0.1
    • 2.0
    • Builds
    • None

    Description

      As above if Bamboo is unable to persist the buildresultsummary (BAM-2487 is an example of how this might occur) it should not run post-build actions and send out notifications - doing so fails with the exception below

      
      2008-04-15 15:30:42,533 INFO [pool-17-thread-1] [NotificationListener] Failed to send Notifications
      java.lang.NullPointerException: attempted to update null
      	at net.sf.hibernate.impl.SessionImpl.update(SessionImpl.java:1342)
      	at com.atlassian.bamboo.notification.NotificationListener.handleEvent(NotificationListener.java:86)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      	at java.lang.reflect.Method.invoke(Method.java:585)
      	at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:304)
      	at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:182)
      	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:149)
      	at org.springframework.orm.hibernate.HibernateInterceptor.invoke(HibernateInterceptor.java:117)
      	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
      	at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
      	at $Proxy36.handleEvent(Unknown Source)
      	at com.atlassian.event.DefaultEventManager$2.run(DefaultEventManager.java:202)
      	at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:650)
      	at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:675)
      	at com.atlassian.bamboo.build.pipeline.concurrent.NamedThreadFactory$1.run(NamedThreadFactory.java:32)
      	at edu.emory.mathcs.backport.java.util.concurrent.helpers.ThreadHelpers$1.run(ThreadHelpers.java:34)
      	at java.lang.Thread.run(Thread.java:595)
      2008-04-15 15:30:42,534 INFO [pool-14-thread-1] [DashboardCacheListener] event: com.atlassian.bamboo.v2.build.events.PostBuildCompletedEvent[source=com.atlassian.bamboo.v2.build.agent.LocalBuildResultProcessor@b4bf2a]
      
      2008-04-15 15:30:42,551 INFO [pool-20-thread-1] [DefaultErrorHandler] Recording error: Automatic Favourite Marker custom build complete action failed to run : 
      java.lang.NullPointerException
      	at com.atlassian.bamboo.results.BuildResultsImpl.getCommits(BuildResultsImpl.java:639)
      	at com.atlassian.bamboo.autofavourite.AutoFavouriteBuildCompleteAction.run(AutoFavouriteBuildCompleteAction.java:44)
      	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      	at java.lang.reflect.Method.invoke(Method.java:585)
      	at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:304)
      	at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:182)
      	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:149)
      	at org.springframework.orm.hibernate.HibernateInterceptor.invoke(HibernateInterceptor.java:117)
      	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
      	at org.springframework.orm.hibernate.HibernateInterceptor.invoke(HibernateInterceptor.java:117)
      	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:171)
      	at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:204)
      	at $Proxy47.run(Unknown Source)
      	at com.atlassian.bamboo.v2.build.events.PostBuildCompletedEventListener.performCustomBuildCompleteAction(PostBuildCompletedEventListener.java:68)
      	at com.atlassian.bamboo.v2.build.events.PostBuildCompletedEventListener.handleEvent(PostBuildCompletedEventListener.java:41)
      	at com.atlassian.event.DefaultEventManager$2.run(DefaultEventManager.java:202)
      	at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:650)
      	at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:675)
      	at com.atlassian.bamboo.build.pipeline.concurrent.NamedThreadFactory$1.run(NamedThreadFactory.java:32)
      	at edu.emory.mathcs.backport.java.util.concurrent.helpers.ThreadHelpers$1.run(ThreadHelpers.java:34)
      	at java.lang.Thread.run(Thread.java:595)
      

      At the very least Bamboo should, notify the user that the buildresultsummary could not be saved

      Attachments

        Issue Links

          Activity

            People

              bmccoy bmccoy
              asridhar AjayA
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: