Uploaded image for project: 'Bamboo Data Center'
  1. Bamboo Data Center
  2. BAM-12158

Git repository password displayed as plain text

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • High
    • 4.4.6, 5.0
    • 4.2
    • Repository (Git)
    • None

    Description

      As shown bellow in some cases username and password(user:passwd@fisheye..)
      are shown to everyone in error message accessible from bamboo System Errors page.

       Build myBuild - Unit Tests - master 36 : Executing Task 'Checkout Default Repository(1)' of type com.atlassian.bamboo.plugins.vcs:task.vcs.checkout.
      (java.lang.RuntimeException : com.atlassian.bamboo.repository.RepositoryException: Cannot fetch branch '(unresolved) ' from 'http://fisheye.domain/git/project.git' to source directory '/home/bamboo/bamboo-agent-home/xml-data/build-dir/MYBUILD-CIUNIT-MASTER'. command [/usr/bin/git, ls-remote, http://user:***@fisheye.domain/git/project.git] failed with code 128. Working directory was [/home/bamboo/bamboo-agent-home/xml-data/build-dir/MYBUILD-CIUNIT-MASTER]., stderr: [error: Failed connect to fisheye.domain:80; Connection refused while accessing http://user:passwd@fisheye.domain/git/project.git/info/refs, fatal: HTTP request failed])
      
      java.lang.RuntimeException: com.atlassian.bamboo.repository.RepositoryException: Cannot fetch branch '(unresolved) ' from 'http://fisheye.domain/git/project.git' to source directory '/home/bamboo/bamboo-agent-home/xml-data/build-dir/MYBUILD-CIUNIT-MASTER'. command [/usr/bin/git, ls-remote, http://user:***@fisheye.domain/git/project.git] failed with code 128. Working directory was [/home/bamboo/bamboo-agent-home/xml-data/build-dir/MYBUILD-CIUNIT-MASTER]., stderr:
      [error: Failed connect to fisheye.domain:80; Connection refused while accessing http://user:passwd@fisheye.domain/git/project.git/info/refs, fatal: HTTP request failed]
      	at com.atlassian.bamboo.executor.RetryingTaskExecutor.rerun(RetryingTaskExecutor.java:119)
      	at com.atlassian.bamboo.executor.RetryingTaskExecutor.runTask(RetryingTaskExecutor.java:79)
      	at com.atlassian.bamboo.executor.RetryingTaskExecutor.retry(RetryingTaskExecutor.java:174)
      	at com.atlassian.bamboo.plugins.vcs.task.VcsCheckoutTask.execute(VcsCheckoutTask.java:109)
      	at com.atlassian.bamboo.task.TaskExecutorImpl.executeTasks(TaskExecutorImpl.java:183)
      	at com.atlassian.bamboo.task.TaskExecutorImpl.executePreparationTasks(TaskExecutorImpl.java:67)
      	at com.atlassian.bamboo.build.pipeline.tasks.PrepareBuildTask.call(PrepareBuildTask.java:67)
      	at com.atlassian.bamboo.v2.build.agent.DefaultBuildAgent.build(DefaultBuildAgent.java:204)
      	at com.atlassian.bamboo.v2.build.agent.BuildAgentControllerImpl.waitAndPerformBuild(BuildAgentControllerImpl.java:103)
      	at com.atlassian.bamboo.v2.build.agent.DefaultBuildAgent$1.run(DefaultBuildAgent.java:109)
      	at com.atlassian.bamboo.build.pipeline.concurrent.NamedThreadFactory$2.run(NamedThreadFactory.java:52)
      	at java.lang.Thread.run(Thread.java:722)
      Caused by: com.atlassian.bamboo.repository.RepositoryException: Cannot fetch branch '(unresolved) ' from 'http://fisheye.domain/git/project.git' to source directory '/home/bamboo/bamboo-agent-home/xml-data/build-dir/MYBUILD-CIUNIT-MASTER'. command [/usr/bin/git, ls-remote, http://user:***@fisheye.domain/git/project.git] failed with code 128. Working directory was [/home/bamboo/bamboo-agent-home/xml-data/build-dir/MYBUILD-CIUNIT-MASTER]., stderr:
      [error: Failed connect to fisheye.domain:80; Connection refused while accessing http://user:passwd@fisheye.domain/git/project.git/info/refs, fatal: HTTP request failed]
      	at com.atlassian.bamboo.plugins.git.NativeGitOperationHelper.fetch(NativeGitOperationHelper.java:432)
      	at com.atlassian.bamboo.plugins.git.GitRepository.retrieveSourceCode(GitRepository.java:358)
      	at com.atlassian.bamboo.plugins.git.GitRepository.retrieveSourceCode(GitRepository.java:292)
      	at com.atlassian.bamboo.plugins.vcs.task.VcsCheckoutTask.fillWorkingDirFromVcs(VcsCheckoutTask.java:180)
      	at com.atlassian.bamboo.plugins.vcs.task.VcsCheckoutTask.access$100(VcsCheckoutTask.java:46)
      	at com.atlassian.bamboo.plugins.vcs.task.VcsCheckoutTask$1.call(VcsCheckoutTask.java:114)
      	at com.atlassian.bamboo.plugins.vcs.task.VcsCheckoutTask$1.call(VcsCheckoutTask.java:110)
      	at com.atlassian.bamboo.executor.RetryingTaskExecutor.rerun(RetryingTaskExecutor.java:100)
      	... 11 more
      Caused by: com.atlassian.bamboo.plugins.git.GitCommandException: command [/usr/bin/git, ls-remote, http://user:***@fisheye.domain/git/project.git] failed with code 128. Working directory was [/home/bamboo/bamboo-agent-home/xml-data/build-dir/MYBUILD-CIUNIT-MASTER]., stderr:
      [error: Failed connect to fisheye.domain:80; Connection refused while accessing http://user:passwd@fisheye.domain/git/project.git/info/refs, fatal: HTTP request failed]
      	at com.atlassian.bamboo.plugins.git.GitCommandProcessor.runCommand(GitCommandProcessor.java:356)
      	at com.atlassian.bamboo.plugins.git.GitCommandProcessor.getRemoteRefs(GitCommandProcessor.java:282)
      	at com.atlassian.bamboo.plugins.git.NativeGitOperationHelper.resolveBranch(NativeGitOperationHelper.java:438)
      	at com.atlassian.bamboo.plugins.git.NativeGitOperationHelper.fetch(NativeGitOperationHelper.java:410)
      	... 18 more
      Caused by: com.atlassian.utils.process.ProcessException: Non-zero exit code: 128
      	at com.atlassian.utils.process.PluggableProcessHandler.complete(PluggableProcessHandler.java:83)
      	at com.atlassian.utils.process.ExternalProcess.finish(ExternalProcess.java:376)
      	at com.atlassian.utils.process.ExternalProcess.execute(ExternalProcess.java:419)
      	at com.atlassian.bamboo.plugins.git.GitCommandProcessor.runCommand(GitCommandProcessor.java:351)
      	... 21 more
      

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              c1fc8681e54f saint
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: